codeant-ai-for-open-source[bot] commented on code in PR #42573: URL: https://github.com/apache/superset/pull/42573#discussion_r3676067301
########## superset-frontend/plugins/plugin-chart-table/src/DataTable/utils/getScrollBarSize.ts: ########## @@ -16,6 +16,11 @@ * specific language governing permissions and limitations * under the License. */ +// Width/height of the custom `::-webkit-scrollbar` applied to the sticky +// body and header sizer in useSticky.tsx. Shared here so the measured +// scrollbar size always matches what actually renders. +export const CUSTOM_SCROLLBAR_SIZE = 8; Review Comment: **Suggestion:** The shared utility now returns the 8px custom scrollbar size in WebKit, but `TableChart.tsx` also uses this value to compensate the outer chart resize container, which does not use the custom `::-webkit-scrollbar` rule. As a result, outer chart dimensions can be adjusted by 8px instead of the actual native scrollbar width, causing incorrect sizing or resize twitching. Keep the native scrollbar measurement for the general utility or provide a separate custom-scrollbar measurement for `StickyWrap`. [api mismatch] <details> <summary><b>Severity Level:</b> Major ⚠️</summary> ```mdx - ⚠️ Table chart resize compensation uses the wrong scrollbar width. - ⚠️ Dashboard resizing can produce incorrect table dimensions. - ⚠️ Chrome and Edge may show resize twitching or layout drift. ``` </details> [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=0e891ec0408347758755230e33a26d15&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=0e891ec0408347758755230e33a26d15&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) *(Use Cmd/Ctrl + Click for best experience)* <details> <summary><b>Prompt for AI Agent 🤖 </b></summary> ```mdx This is a comment left during a code review. **Path:** superset-frontend/plugins/plugin-chart-table/src/DataTable/utils/getScrollBarSize.ts **Line:** 22:22 **Comment:** *Api Mismatch: The shared utility now returns the 8px custom scrollbar size in WebKit, but `TableChart.tsx` also uses this value to compensate the outer chart resize container, which does not use the custom `::-webkit-scrollbar` rule. As a result, outer chart dimensions can be adjusted by 8px instead of the actual native scrollbar width, causing incorrect sizing or resize twitching. Keep the native scrollbar measurement for the general utility or provide a separate custom-scrollbar measurement for `StickyWrap`. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42573&comment_hash=12e21fd6e33f9e99b556c258cfcbf9db9632a8e1c32291715e5a7b2afa29fb32&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42573&comment_hash=12e21fd6e33f9e99b556c258cfcbf9db9632a8e1c32291715e5a7b2afa29fb32&reaction=dislike'>👎</a> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
