Abdulrehman-PIAIC80387 commented on PR #42463: URL: https://github.com/apache/superset/pull/42463#issuecomment-5127277793
Thanks for the review @rusackas — updated. Swapped the SQL-text sniff for a dedicated `SupersetVirtualTableParseException` subclass of `SupersetGenericDBErrorException`, raised only at the two template/parse sites in `get_virtual_table_metadata`. `RefreshDatasetCommand` now catches just that subclass, so a real driver/connection/permission error on a Jinja-templated dataset (still raised as the base class from `get_columns_description`'s catch-all) bubbles up unchanged. Added a regression test covering exactly that case: Jinja SQL + `SupersetGenericDBErrorException` → still raises. Happy to iterate further — let me know if you'd prefer the subclass to live somewhere other than `exceptions.py`, or if the naming/scope should change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
