rusackas commented on PR #40635: URL: https://github.com/apache/superset/pull/40635#issuecomment-5136225327
@ytihianine sorry for the silence, went a bit deeper on this than I expected. I rebased it properly instead of just re-running the merge scripts, that path was going to blow away a bunch of your actual translation work. Did a msgid-by-msgid comparison between the merge-base, your branch, and current `master` instead of trusting a line-level git diff, since `.po` files reformat too much for that to mean anything. Your translations won by default everywhere. I only took `master`'s version where it had independently fixed something you hadn't touched since the merge base (a handful of typos, a couple of "Echec" missing the accent, that kind of thing), and caught a few more of the same pattern while I was in there. On `% of parent`/`% of total`/`% calculation`: it's a Babel false positive, not a real bug. `no-python-format` doesn't actually suppress its compile-time check, and it misreads the plain word "of" as a `%o` placeholder. Confirmed the compiled `.mo` resolves those correctly at runtime regardless of the warning, so I left them as `no-python-format`, non-fuzzy, matching the POT's own flags. Duplicate msgids look clean now. Ran it through `check_translation_regression.py`, the same thing the bot runs, 0 regressions. Force-pushed to `i18n-french` since it needed a real rebase. Running CI 🤞, let me know if anything looks off. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
