sadpandajoe opened a new pull request, #42654: URL: https://github.com/apache/superset/pull/42654
### SUMMARY Narrow the nullable SQLAlchemy UUID attributes in the chart, dashboard, and dataset version-restore integration tests before passing them to `derive_version_uuid`. The scheduled pre-commit workflow on master reported 14 MyPy `arg-type` errors after #42469 introduced these tests. The model fields are typed as `UUID | None`, while the helper correctly requires `UUID`. Explicit non-null assertions at the test setup boundaries retain the runtime test behavior and satisfy the stricter contract. Observed failure: https://github.com/apache/superset/actions/runs/30611617987 ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Not applicable; test-only typing fix. ### TESTING INSTRUCTIONS - `pre-commit run mypy --files tests/integration_tests/charts/version_restore_tests.py tests/integration_tests/dashboards/version_restore_tests.py tests/integration_tests/datasets/version_restore_tests.py` - `pre-commit run --files tests/integration_tests/charts/version_restore_tests.py tests/integration_tests/dashboards/version_restore_tests.py tests/integration_tests/datasets/version_restore_tests.py` - `pre-commit run --all-files` was run. The affected MyPy hook passed; unrelated local baseline/environment failures remained in docs/frontend tooling and repository-wide linting. - The three pytest files were attempted, but the host environment failed before collection because its `pytest-cov` plugin imports `coverage.results.display_covered`, which is absent from the installed `coverage` package. ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
