eschutho commented on PR #42273: URL: https://github.com/apache/superset/pull/42273#issuecomment-5145988644
Rebased onto current master (single clean commit, replacing the previous merge-commit history; the separate ruff-format style commit is folded in). Per review guidance, verified the fail-loud change still composes cleanly with the newly merged readiness flow (#42253/#42427): - The unguarded `_get_screenshot` fallback block this PR removes was untouched by the readiness merges — the cherry-pick applied without conflicts. - The raised `PlaywrightTimeout` still propagates: the enclosing handler in `get_screenshot` re-raises `PlaywrightTimeout` before the `PlaywrightError` catch-all, so the report fails loudly as intended. - `tests/unit_tests/utils/` — 713 passed locally; `ruff check` + `ruff format --check` clean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
