bito-code-review[bot] commented on code in PR #35777:
URL: https://github.com/apache/superset/pull/35777#discussion_r3693323743
##########
superset-frontend/src/components/Chart/ChartRenderer.test.tsx:
##########
@@ -423,3 +431,76 @@ test('does not render chart during loading when last data
has errors', () => {
const { queryByTestId } = render(<ChartRenderer {...props} />);
expect(queryByTestId('mock-super-chart')).not.toBeInTheDocument();
});
+
+// Legend state persistence (sessionStorage) — issue #31741
+type LegendHooks = {
+ onLegendStateChanged: (legendState: JsonObject) => void;
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Type mismatch in hook parameter</b></div>
<div id="fix">
Import `LegendState` from the component and update `LegendHooks` so that
`onLegendStateChanged` uses `(legendState: LegendState) => void` instead of
`JsonObject`.
</div>
</div>
<small><i>Code Review Run #a90483</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
