rusackas commented on code in PR #42542:
URL: https://github.com/apache/superset/pull/42542#discussion_r3693857526
##########
superset/db_engine_specs/base.py:
##########
@@ -317,6 +347,11 @@ class DBEngineSpecMetadata(TypedDict, total=False):
install_instructions: str
version_requirements: str
+ # Known, currently-unresolved incompatibilities with a Superset
+ # dependency (e.g. a driver that doesn't yet support SQLAlchemy 2.0).
+ # Hopefully temporary; remove the entry once resolved upstream.
+ known_incompatibilities: list[KnownIncompatibility]
Review Comment:
Good catch, added the `KnownIncompatibility` TS type and rendered it in
`DatabasePage.tsx`, both at the top level and inside each compatible-database
entry, so this doesn't just sit unused in the JSON anymore.
##########
superset/db_engine_specs/mysql.py:
##########
@@ -183,6 +184,7 @@ class MySQLEngineSpec(BasicParametersMixin, BaseEngineSpec):
DatabaseCategory.CLOUD_AWS,
DatabaseCategory.HOSTED_OPEN_SOURCE,
],
+ "known_incompatibilities":
AURORA_DATA_API_KNOWN_INCOMPATIBILITIES,
Review Comment:
Good catch, taught the AST fallback extractor to resolve module-level
constants so `AURORA_DATA_API_KNOWN_INCOMPATIBILITIES` serializes to the actual
list instead of the bare name. Went with resolving it over inlining, keeps the
DRY reasoning behind that shared entry.
##########
superset/db_engine_specs/d1.py:
##########
@@ -48,4 +48,15 @@ class CloudflareD1EngineSpec(SqliteEngineSpec):
"cloudflare_d1_database_id": "D1 database ID",
},
"install_instructions": "pip install superset-engine-d1",
+ "known_incompatibilities": [
+ {
+ "dependency": "SQLAlchemy 2.0",
+ "reason": (
+ "sqlalchemy-d1 is very young (single release, Nov 2025); "
+ "no confirmed SQLAlchemy 2.0 support either way yet."
+ ),
+ "tracking_url":
("https://github.com/sqlalchemy-cf-d1/sqlalchemy-d1";),
Review Comment:
Good catch, checked PyPI and sqlalchemy-d1's only release does pin
`sqlalchemy<2,>=1.4`. Updated the reason text to say it explicitly excludes
SQLAlchemy 2.0 rather than just lacking confirmation either way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
