jayvenn21 commented on PR #37773: URL: https://github.com/apache/superset/pull/37773#issuecomment-5159868920
Thanks for the review @rusackas. I rebased this on the latest `master` and updated the implementation to skip registering the legacy FAB password views directly rather than registering them and removing them afterward. I also ran `pre-commit run --all-files`, which is passing now. I did spot-check the related auth tests as well as the unit coverage passes locally. The only local hiccup I hit was with the integration test setup, where my SQLite test DB is missing the `tables.deleted_at` column, so that looks like an environment/schema issue rather than something from this change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
