bito-code-review[bot] commented on code in PR #42053:
URL: https://github.com/apache/superset/pull/42053#discussion_r3700379533
##########
superset-frontend/packages/superset-ui-chart-controls/src/types.ts:
##########
@@ -507,7 +508,7 @@ export type ColorFormatters = {
objectFormatting?: ObjectFormattingEnum;
getColorFromValue: (
value: number | string | boolean | null,
- ) => string | undefined;
+ ) => RgbaColor | string | undefined;
Review Comment:
<!-- Bito Reply -->
The suggestion is correct. The implementation in the referenced file
consistently returns hex color strings or undefined, and does not return an
`RgbaColor` object. Updating the type annotation to exclude `RgbaColor`
improves type accuracy.
**superset-frontend/packages/superset-ui-chart-controls/src/types.ts**
```
getColorFromValue: (
value: number | string | boolean | null,
) => string | undefined;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
