ARBS-23 opened a new issue, #42704: URL: https://github.com/apache/superset/issues/42704
### Bug description In Explore (Add/Edit Chart), when editing a dataset via the dataset overflow menu → **Edit dataset**, a metric's **Warning** text does not reappear after save/reopen — even though: - the yellow warning icon still shows next to the metric name - the same Warning value displays correctly when editing the dataset from **Datasets → Edit dataset** This suggests the value is persisted, but the Explore-opened Edit Dataset modal does not rehydrate the Warning field correctly (possible `warning_text` vs `extra.warning_markdown` mapping mismatch between entry points). ### How to reproduce the bug 1. Log in as a user with dataset edit permission 2. Go to **Charts** → edit an existing chart, or create a new chart 3. In Chart Source, click `...` beside the dataset name → **Edit dataset** 4. Open the **Metrics** tab 5. Expand a metric's details (`+`) 6. Enter text in the **Warning** field (optionally fill Certified by / Certification details) 7. Click **Save** 8. Reopen the same Edit Dataset modal from Explore (`...` → Edit dataset) and expand the same metric ### Screenshots/recordings Screenshot 1 — Warning text entered before save: https://github.com/user-attachments/assets/043da1f1-c207-4512-ac31-ae53a6a01d34 Screenshot 2 — After save/reopen from Explore: Warning field blank, warning icon still present: https://github.com/user-attachments/assets/4232d1b4-92a0-4bff-bca6-2d8d50ddc088 ### Expected behavior After save and reopen from Explore → Edit dataset, the **Warning** text area should show the saved value, and the warning icon should remain next to the metric name. ### Actual behavior - Warning field is blank after reopen from Explore - Warning icon still appears (value appears persisted) - Opening **Datasets → Edit dataset** for the same dataset does show the Warning text correctly ### Superset version 6.1.0 (also observed on a deployment based on `apache/superset:6.1.0-py311`) ### Python version 3.11 ### Node version I don't know ### Browser Chrome ### Additional context - Related historical context: metrics previously had a top-level `warning_text` column and later moved toward `extra.warning_markdown` (see discussion on https://github.com/apache/superset/pull/13606). A field-name mismatch between the Explore datasource modal and Datasets edit form would explain icon-present / text-blank behavior. - Related serialization work: https://github.com/apache/superset/pull/39706 (`buildExtraJsonObject` / `warning_markdown`) - Internal tracker reference (optional): gigaphoton/fabscape-superset#145 ### Checklist - [x] I have searched Superset docs and Stack Overflow for this problem and didn't find a solution to it. - [x] I have searched for existing issues and couldn't find a similar issue. - [x] I have checked that this bug appears on the latest released Superset. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
