MallikarjunaReddyN opened a new pull request, #42706: URL: https://github.com/apache/superset/pull/42706
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> This PR fixes an issue with **server-side pagination** in **Table Charts** where filtering on **custom SQL expression (adhoc) columns** was not applied correctly. When a filter targeted an adhoc column, the generated server-side query failed to include the corresponding SQL expression in the filtering logic, causing all records to be returned instead of only the matching rows. The query generation has been updated to correctly resolve and apply adhoc column expressions during server-side filtering, ensuring consistent behavior between physical dataset columns and custom SQL expression columns. Additionally, this PR fixes a pagination UI issue where the **page size** was incorrectly displayed as 0 when the total number of returned records was less than the configured **Server Page Length**. The page size is now calculated based on the actual number of records returned, providing accurate pagination information. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> Before: https://github.com/user-attachments/assets/908ffbaf-75e7-4f6a-a7e3-14d8a816c63c After: https://github.com/user-attachments/assets/5f4fbb6f-b2c7-4ed9-ac47-413e6ce9eb3f ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: https://github.com/apache/superset/issues/38339 - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
