mikebridge commented on PR #41550: URL: https://github.com/apache/superset/pull/41550#issuecomment-5166842536
Follow-up to the [self-review pass](https://github.com/apache/superset/pull/41550#issuecomment-5166719110) above — both Warnings and the Suggestion are addressed in `efb0e178e2`: - **W1**: bulk delete and the modal's semantic-view count now discriminate on `kind === 'semantic_view'` (required field, schema Constant), matching the row actions and export. The two predicates are the same expression, so the recoverability copy can't disagree with what the handler deletes. - **W2**: `ArchivedItem` declares `deleted_at_delta_humanized?: string | null`, with a docstring pointing at `_inject_deleted_at` for the nullability. - **S3**: the six soft-delete rison operators are `ListViewFilterOperator` members now (following the `ChartAllText` precedent), the archive config uses them, and the `as FilterOperator` cast is gone. One test change worth noting: the mixed-selection integration fixture had `source_type: 'semantic_layer'` without `kind: 'semantic_view'` — a row the combined endpoint cannot emit, since `SemanticViewListSchema` serializes both as Constants. The fixture now carries both. Its failure against the new predicate (until it matched the wire) is what demonstrates the test actually binds the discriminator, rather than passing either way. `3cb75cd8b1` also adds the `Archived within` filter label to `messages.pot` — it arrived in `superset/views/filters.py` with the review-round commit `0ce35d8224`, after this branch's catalogue regeneration, so the template had never picked it up. Verified: `tsc --noEmit` clean, 130/130 across the seven ArchivedList/DatasetList suites, pre-commit green. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
