rusackas commented on code in PR #42711:
URL: https://github.com/apache/superset/pull/42711#discussion_r3706956389
##########
superset/versioning/queries.py:
##########
@@ -133,13 +132,17 @@ def _changed_by_from_row(row: Any) -> dict[str, Any] |
None:
``changed_by`` shape, or ``None`` for saves with no Flask user context
(CLI / Celery / import / unauthenticated). Expects the user columns to
have been selected via :func:`_user_select_cols` so the row keys are
- ``user_id`` / ``username`` / ``first_name`` / ``last_name``.
+ ``user_id`` / ``first_name`` / ``last_name``.
"""
if row["user_id"] is None:
return None
+ # Deliberately no ``username``: it is a login identifier, not display
+ # data. The version and activity attribution shapes are kept identical
+ # so clients share one type — enforced by
+ # test_version_and_activity_attribution_schemas_match in
+ # tests/unit_tests/versioning/test_queries.py.
Review Comment:
Not sure we need all the comments about tests, but ¯\\\_(ツ)_/¯
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
