sadpandajoe commented on code in PR #42488:
URL: https://github.com/apache/superset/pull/42488#discussion_r3708064989
##########
.github/workflows/superset-docs-deploy.yml:
##########
@@ -47,17 +37,68 @@ jobs:
env:
SUPERSET_SITE_BUILD: ${{ (secrets.SUPERSET_SITE_BUILD != '' &&
secrets.SUPERSET_SITE_BUILD != '') || '' }}
+
+ # Master gets frequent, sometimes bursty pushes, and each one can trigger a
+ # deploy attempt. Rather than let every superseded attempt get force-killed
+ # by the build-deploy concurrency group below (which shows up as a
+ # `cancelled` — i.e. red/failing-looking — check on that commit), have each
+ # run check up front whether it's still building master's current tip and,
+ # if not, skip cleanly. Deliberately outside the docs-deploy-asf-site
+ # concurrency group so it runs immediately for every trigger without
+ # blocking or being blocked by anything.
+ check-freshness:
+ runs-on: ubuntu-26.04
+ outputs:
+ is-current: ${{ steps.check.outputs.is-current }}
+ steps:
+ - name: "Check whether this is still master's current commit"
+ id: check
+ env:
+ GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+ BUILD_SHA: ${{ github.event.workflow_run.head_sha || github.sha }}
+ EVENT_NAME: ${{ github.event_name }}
+ run: |
Review Comment:
The full GitHub scheduler matrix would need infrastructure this repo does
not have, agreed. But the regression caught here was inside the shell gate
itself: a focused test can execute that script with a stubbed `gh` and
`GITHUB_OUTPUT` for dispatch, current-tip, and stale-tip inputs, without
introducing `act`; could we cover that narrower boundary so the dispatch bypass
and output contract cannot regress?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
