bito-code-review[bot] commented on code in PR #42731: URL: https://github.com/apache/superset/pull/42731#discussion_r3709739537
########## superset/sql/parse.py: ########## @@ -48,7 +48,15 @@ ) from superset.exceptions import QueryClauseValidationException, SupersetParseError -from superset.sql.dialects import DB2, Dremio, Firebolt, OpenSearch, Pinot, Vertica +from superset.sql.dialects import ( + DB2, + Dremio, + Firebolt, + Hana, + OpenSearch, + Pinot, + Vertica, +) Review Comment: <!-- Bito Reply --> The suggestion from the reviewer is to add an explicit registration test for the newly added `Hana` dialect, following the pattern used for other custom dialects like Pinot and OpenSearch. This is a standard practice to ensure that future refactors do not inadvertently break the dialect mapping. Applying this suggestion is appropriate as it improves the test coverage and maintainability of the dialect registration logic. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
