rusackas commented on code in PR #42602: URL: https://github.com/apache/superset/pull/42602#discussion_r3709798973
########## superset-frontend/packages/superset-core/src/theme/SupersetThemeProvider.test.tsx: ########## @@ -0,0 +1,205 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import { useLayoutEffect, type ReactNode } from 'react'; +import { render, screen, act } from '@testing-library/react'; +import { theme as antdThemeImport } from 'antd'; +import { Theme } from './Theme'; + +// SupersetThemeProvider stores theme state via React.useState, then +// registers a listener (in a useEffect, on mount) that calls setThemeState +// whenever a *later* call to setConfig/toggleDarkMode runs on the same +// Theme instance. Every provider currently mounted from that instance +// listens independently, so toggling the instance updates all of them, not +// just the most recently rendered one. Consumers +// (docs/src/components/StorybookWrapper.jsx in particular) rely on this: +// they call toggleDarkMode() from outside, on one or more already-mounted +// providers sharing a single Theme instance, expecting it to propagate to +// all of them. +// +// The probe below reads the theme via antd's theme.useToken() -- the same +// context-consumption path every real antd component (Button, Input, ...) +// uses internally -- rather than reading themeObject.theme directly off the +// singleton. That distinction matters: React bails out of re-rendering a +// child whose element reference didn't change (the common "static children +// prop" case, true here since <Probe /> is passed once and never +// recreated), UNLESS that child consumes a React Context whose value +// changed, which bypasses the bail-out. A probe reading the plain object +// directly would misleadingly appear "not updated" even though every real +// themed component downstream re-renders correctly. +function makeProbe() { + let renderCount = 0; + let lastColorBgBase: string | undefined; + function Probe() { + const { token } = antdThemeImport.useToken(); + renderCount += 1; + lastColorBgBase = token.colorBgBase; + return <div data-test="probe" />; Review Comment: Not a bug — `spec/helpers/setup.ts` configures RTL's `testIdAttribute` as `data-test`, so `getByTestId` matches `data-test` here, not `data-testid`. Same claim, same answer as the earlier thread on this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
