bito-code-review[bot] commented on code in PR #39434:
URL: https://github.com/apache/superset/pull/39434#discussion_r3715321874
##########
superset-frontend/src/dashboard/components/PropertiesModal/sections/AdvancedSection.tsx:
##########
@@ -22,6 +22,7 @@ import type { editors } from '@apache-superset/core';
import { EditorHost } from 'src/core/editors';
import { ModalFormField } from 'src/components/Modal';
import { ValidationObject } from 'src/components/Modal/useModalValidation';
+import LabelColorMapping from './LabelColorMapping';
type EditorAnnotation = editors.EditorAnnotation;
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing test coverage for new component</b></div>
<div id="fix">
AdvancedSection.test.tsx has 6 tests but none verify LabelColorMapping
behavior. Tests should assert that the component renders correctly and that
color mapping operations (add/update/delete rows) trigger onJsonMetadataChange
with correct JSON updates per BITO.md rule [6262].
</div>
</div>
<small><i>Code Review Run #51a83c</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
