gkneighb commented on PR #42372: URL: https://github.com/apache/superset/pull/42372#issuecomment-5184078232
@DamianPendrak fixed in `6d51c6a562`. The stale sort key is handled by mirroring the shared `xAxisSortControl` — `shouldMapStateToProps: () => true` plus a `shouldReset` flag that clears `x_axis_sort` once its value is no longer a current column or metric, so a stale metric label can't reach `buildQuery` and leak in as an unknown column. Added a control-panel test covering the reset. Also addressed the two AI comments: - Reworded the "Sort ascending" description to say it orders the X-axis categories by the selected sort field (not "on the X-axis"). - Removed the `xAxisSort`/`xAxisSortAsc` fields from `EchartsWaterfallFormData` — that type is the camelCase transformProps shape, but sorting is read as raw snake-case `x_axis_sort` in `buildQuery`, so those fields were dead and misleading. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
