rusackas commented on PR #39257: URL: https://github.com/apache/superset/pull/39257#issuecomment-5185859711
@Vikash-Kumar-23 good to see the canEdit prop and the datasource-label-cell width both cleaned up, and no more conflicts with master. Before we can merge this though, the resizableConfig you're passing in DatasourceModal/index.tsx (around the defaultSize/maxWidth/maxHeight block) replaces Modal's whole default config instead of extending it, so it drops minWidth/minHeight and the enable directions Modal.tsx normally sets. That means the modal can be resized down to nothing, and reopens resize handles on sides we deliberately turned off. Mind adding those back into your override? Also a few Codeant threads on sortColumns and the initialValue staleness in TextAreaControl are still open, worth a look in the same pass. Holler if you want a hand with any of this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
