codeant-ai-for-open-source[bot] commented on code in PR #32958:
URL: https://github.com/apache/superset/pull/32958#discussion_r3717344830
##########
superset-frontend/src/dashboard/actions/hydrate.ts:
##########
@@ -375,6 +375,7 @@ export const hydrateDashboard =
directPathLastUpdated: Date.now(),
focusedFilterField: null,
expandedSlices: metadata?.expanded_slices || {},
+ expandAllSlices: metadata?.expand_all_slices || false,
Review Comment:
✅ **Customized review instruction saved!**
**Instruction:**
> Do not special-case boolean normalization for individual dashboard
metadata fields in the frontend; address boolean coercion consistently across
DashboardJSONMetadataSchema instead.
**Applied to:**
- `superset-frontend/src/dashboard/actions/hydrate.ts`
---
💡 *To manage or update this instruction, visit: [CodeAnt AI
Settings](https://app.codeant.ai/org/settings/learnings)*
##########
superset/daos/dashboard.py:
##########
@@ -341,6 +341,7 @@ def set_dash_metadata(
md["color_namespace"] = data.get("color_namespace")
md["expanded_slices"] = data.get("expanded_slices", {})
+ md["expand_all_slices"] = data.get("expand_all_slices", False)
Review Comment:
✅ **Customized review instruction saved!**
**Instruction:**
> Do not flag boolean metadata fields for lacking type coercion on save when
they are already validated and follow the existing dashboard metadata pattern.
**Applied to:**
- `superset/daos/dashboard.py`
---
💡 *To manage or update this instruction, visit: [CodeAnt AI
Settings](https://app.codeant.ai/org/settings/learnings)*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
