rusackas commented on code in PR #32958:
URL: https://github.com/apache/superset/pull/32958#discussion_r3717352756
##########
superset-frontend/spec/fixtures/mockDashboardState.js:
##########
@@ -113,6 +113,6 @@ export const overwriteConfirmMetadata = {
slug: null,
owners: [],
json_metadata:
-
'{"timed_refresh_immune_slices":[],"expanded_slices":{},"refresh_frequency":0,"default_filters":"{}","color_scheme":"supersetColors","label_colors":{"0":"#FCC700","1":"#A868B7","15":"#3CCCCB","30":"#A38F79","45":"#8FD3E4","age":"#1FA8C9","Yes,":"#1FA8C9","Female":"#454E7C","Prefer":"#5AC189","No,":"#FF7F44","Male":"#666666","Prefer
not to say":"#E04355","Ph.D.":"#FCC700","associate\'s
degree":"#A868B7","bachelor\'s degree":"#3CCCCB","high school diploma or
equivalent (GED)":"#A38F79","master\'s degree (non-professional)":"#8FD3E4","no
high school (secondary school)":"#A1A6BD","professional degree (MBA, MD, JD,
etc.)":"#ACE1C4","some college credit, no degree":"#FEC0A1","some high
school":"#B2B2B2","trade, technical, or vocational training":"#EFA1AA","No, not
an ethnic minority":"#1FA8C9","Yes, an ethnic
minority":"#454E7C","<NULL>":"#5AC189","Yes":"#FF7F44","No":"#666666","last_yr_income":"#E04355","More":"#A1A6BD","Less":"#ACE1C4","I":"#FEC0A1","expected_earn":"#B2B2B2","Yes:
Willing To":"#EFA1AA","No: Not Willing to":"#FDE380","No
Answer":"#D3B3DA","In an Office (with Other Developers)":"#9EE5E5","No
Preference":"#D1C6BC","From
Home":"#1FA8C9"},"color_scheme_domain":["#1FA8C9","#454E7C","#5AC189","#FF7F44","#666666","#E04355","#FCC700","#A868B7","#3CCCCB","#A38F79","#8FD3E4","#A1A6BD","#ACE1C4","#FEC0A1","#B2B2B2","#EFA1AA","#FDE380","#D3B3DA","#9EE5E5","#D1C6BC"],"shared_label_colors":["Male",
"Female","<NULL>","Prefer not to say","No Answer","Yes, an ethnic
minority","No, not an ethnic
minority","age"],"cross_filters_enabled":false,"filter_scopes":{},"chart_configuration":{},"positions":{}}',
+
'{"timed_refresh_immune_slices":[],"expanded_slices":{},"expand_all_slices":"false","refresh_frequency":0,"default_filters":"{}","color_scheme":"supersetColors","label_colors":{"0":"#FCC700","1":"#A868B7","15":"#3CCCCB","30":"#A38F79","45":"#8FD3E4","age":"#1FA8C9","Yes,":"#1FA8C9","Female":"#454E7C","Prefer":"#5AC189","No,":"#FF7F44","Male":"#666666","Prefer
not to say":"#E04355","Ph.D.":"#FCC700","associate\'s
degree":"#A868B7","bachelor\'s degree":"#3CCCCB","high school diploma or
equivalent (GED)":"#A38F79","master\'s degree (non-professional)":"#8FD3E4","no
high school (secondary school)":"#A1A6BD","professional degree (MBA, MD, JD,
etc.)":"#ACE1C4","some college credit, no degree":"#FEC0A1","some high
school":"#B2B2B2","trade, technical, or vocational training":"#EFA1AA","No, not
an ethnic minority":"#1FA8C9","Yes, an ethnic
minority":"#454E7C","<NULL>":"#5AC189","Yes":"#FF7F44","No":"#666666","last_yr_income":"#E04355","More":"#A1A6BD","Less":"#ACE1C4","I":"#FEC0A1","ex
pected_earn":"#B2B2B2","Yes: Willing To":"#EFA1AA","No: Not Willing
to":"#FDE380","No Answer":"#D3B3DA","In an Office (with Other
Developers)":"#9EE5E5","No Preference":"#D1C6BC","From
Home":"#1FA8C9"},"color_scheme_domain":["#1FA8C9","#454E7C","#5AC189","#FF7F44","#666666","#E04355","#FCC700","#A868B7","#3CCCCB","#A38F79","#8FD3E4","#A1A6BD","#ACE1C4","#FEC0A1","#B2B2B2","#EFA1AA","#FDE380","#D3B3DA","#9EE5E5","#D1C6BC"],"shared_label_colors":["Male",
"Female","<NULL>","Prefer not to say","No Answer","Yes, an ethnic
minority","No, not an ethnic
minority","age"],"cross_filters_enabled":false,"filter_scopes":{},"chart_configuration":{},"positions":{}}',
Review Comment:
This fixture predates the PR and is only getting a one-line value change
here, I'd rather not bundle an unrelated .js to .ts migration into this diff.
##########
superset-frontend/spec/fixtures/mockDashboardState.js:
##########
@@ -114,6 +114,6 @@ export const overwriteConfirmMetadata = {
editors: [],
viewers: [],
json_metadata:
-
'{"timed_refresh_immune_slices":[],"expanded_slices":{},"refresh_frequency":0,"default_filters":"{}","color_scheme":"supersetColors","label_colors":{"0":"#FCC700","1":"#A868B7","15":"#3CCCCB","30":"#A38F79","45":"#8FD3E4","age":"#1FA8C9","Yes,":"#1FA8C9","Female":"#454E7C","Prefer":"#5AC189","No,":"#FF7F44","Male":"#666666","Prefer
not to say":"#E04355","Ph.D.":"#FCC700","associate\'s
degree":"#A868B7","bachelor\'s degree":"#3CCCCB","high school diploma or
equivalent (GED)":"#A38F79","master\'s degree (non-professional)":"#8FD3E4","no
high school (secondary school)":"#A1A6BD","professional degree (MBA, MD, JD,
etc.)":"#ACE1C4","some college credit, no degree":"#FEC0A1","some high
school":"#B2B2B2","trade, technical, or vocational training":"#EFA1AA","No, not
an ethnic minority":"#1FA8C9","Yes, an ethnic
minority":"#454E7C","<NULL>":"#5AC189","Yes":"#FF7F44","No":"#666666","last_yr_income":"#E04355","More":"#A1A6BD","Less":"#ACE1C4","I":"#FEC0A1","expected_earn":"#B2B2B2","Yes:
Willing To":"#EFA1AA","No: Not Willing to":"#FDE380","No
Answer":"#D3B3DA","In an Office (with Other Developers)":"#9EE5E5","No
Preference":"#D1C6BC","From
Home":"#1FA8C9"},"color_scheme_domain":["#1FA8C9","#454E7C","#5AC189","#FF7F44","#666666","#E04355","#FCC700","#A868B7","#3CCCCB","#A38F79","#8FD3E4","#A1A6BD","#ACE1C4","#FEC0A1","#B2B2B2","#EFA1AA","#FDE380","#D3B3DA","#9EE5E5","#D1C6BC"],"shared_label_colors":["Male",
"Female","<NULL>","Prefer not to say","No Answer","Yes, an ethnic
minority","No, not an ethnic
minority","age"],"cross_filters_enabled":false,"filter_scopes":{},"chart_configuration":{},"positions":{}}',
+
'{"timed_refresh_immune_slices":[],"expanded_slices":{},"expand_all_slices":"false","refresh_frequency":0,"default_filters":"{}","color_scheme":"supersetColors","label_colors":{"0":"#FCC700","1":"#A868B7","15":"#3CCCCB","30":"#A38F79","45":"#8FD3E4","age":"#1FA8C9","Yes,":"#1FA8C9","Female":"#454E7C","Prefer":"#5AC189","No,":"#FF7F44","Male":"#666666","Prefer
not to say":"#E04355","Ph.D.":"#FCC700","associate\'s
degree":"#A868B7","bachelor\'s degree":"#3CCCCB","high school diploma or
equivalent (GED)":"#A38F79","master\'s degree (non-professional)":"#8FD3E4","no
high school (secondary school)":"#A1A6BD","professional degree (MBA, MD, JD,
etc.)":"#ACE1C4","some college credit, no degree":"#FEC0A1","some high
school":"#B2B2B2","trade, technical, or vocational training":"#EFA1AA","No, not
an ethnic minority":"#1FA8C9","Yes, an ethnic
minority":"#454E7C","<NULL>":"#5AC189","Yes":"#FF7F44","No":"#666666","last_yr_income":"#E04355","More":"#A1A6BD","Less":"#ACE1C4","I":"#FEC0A1","ex
pected_earn":"#B2B2B2","Yes: Willing To":"#EFA1AA","No: Not Willing
to":"#FDE380","No Answer":"#D3B3DA","In an Office (with Other
Developers)":"#9EE5E5","No Preference":"#D1C6BC","From
Home":"#1FA8C9"},"color_scheme_domain":["#1FA8C9","#454E7C","#5AC189","#FF7F44","#666666","#E04355","#FCC700","#A868B7","#3CCCCB","#A38F79","#8FD3E4","#A1A6BD","#ACE1C4","#FEC0A1","#B2B2B2","#EFA1AA","#FDE380","#D3B3DA","#9EE5E5","#D1C6BC"],"shared_label_colors":["Male",
"Female","<NULL>","Prefer not to say","No Answer","Yes, an ethnic
minority","No, not an ethnic
minority","age"],"cross_filters_enabled":false,"filter_scopes":{},"chart_configuration":{},"positions":{}}',
Review Comment:
Same as the other thread on this file, out of scope for this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
