bito-code-review[bot] commented on code in PR #33924:
URL: https://github.com/apache/superset/pull/33924#discussion_r3717371543
##########
tests/integration_tests/security/api_tests.py:
##########
@@ -195,6 +195,174 @@ def test_post_guest_token_authorized(self):
assert user == decoded_token["user"]
assert resource == decoded_token["resources"][0]
+ @pytest.mark.usefixtures("load_birth_names_dashboard_with_slices")
+ def test_post_guest_token_with_attributes(self) -> None:
Review Comment:
<!-- Bito Reply -->
The suggestion to add type hints to all test methods in the file is intended
to maintain consistency with project standards. While it is acceptable to
prioritize the current changes, applying the suggestion to the entire class
would improve overall code quality and adhere to the project's type-hinting
rules.
**tests/integration_tests/security/api_tests.py**
```
@pytest.mark.usefixtures("load_birth_names_dashboard_with_slices")
def test_post_guest_token_with_attributes(self) -> None:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
