rusackas commented on PR #38741:
URL: https://github.com/apache/superset/pull/38741#issuecomment-5187392036
@msyavuz fair point, and I've been poking at the same question. Threading
`overlayClassName` around for one use case, backed by a page-scoped global CSS
block, is a little icky.
Went looking for the clean fix though. AntD v6's Tooltip only has arrow
tokens on its `ComponentToken`, no `fontSize` slot, so there's no
`theme.components.Tooltip.fontSize` to reach for. Going fully global
(`.ant-tooltip-inner` unscoped) would touch ~45 other Tooltip usages just under
`src/dashboard/`, none of them checked for this.
Middle ground I like better: wrap just this `Tooltip` in `AntdThemeProvider`
(already used for scoped config in `ChartHolder.tsx`) with `theme={{ token: {
fontSize: theme.fontSizeSM } }}`. One instance, no classname plumbing, no
global stylesheet, and it reaches the portaled content since it's context, not
a classname match.
@Mayankaggarwal8055 mind giving that a shot?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
