bito-code-review[bot] commented on code in PR #42655:
URL: https://github.com/apache/superset/pull/42655#discussion_r3717945496
##########
superset/mcp_service/chart/schemas.py:
##########
@@ -2347,6 +2347,14 @@ class UpdateChartRequest(ChartRequestNormalizerMixin,
QueryCacheControl):
None,
description="Chart configuration. Optional; omit to only update
chart_name.",
)
+ add_columns: List[ColumnRef] | None = Field(
+ None,
+ description=(
+ "Table columns or metrics to append while preserving every
existing "
+ "column and metric. Use this instead of config.columns when adding
"
+ "columns to an existing table chart."
+ ),
+ )
Review Comment:
<!-- Bito Reply -->
It is good to hear that the coverage gaps have been addressed and that the
additional testing led to the discovery of a bug. The addition of
`TestUpdateChartRequestColumnPatchValidation` to cover both error branches and
the valid additive shape is an appropriate way to resolve the concern regarding
missing test coverage for the new field.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
