bito-code-review[bot] commented on PR #42786:
URL: https://github.com/apache/superset/pull/42786#issuecomment-5187708583
<!-- Bito Reply -->
The flagged issue is correct. The current implementation of
`forceLoadAllCharts` in `superset-frontend/src/utils/downloadUtils.ts` already
addresses this by introducing batching and a per-batch timeout
(`BATCH_LOAD_TIMEOUT_MS`), followed by a final `waitForChartsToLoad` call that
acts as the overall safety net. The implementation ensures that a slow chart in
one batch does not block subsequent batches, and the final check ensures that
any stragglers are accounted for before the export proceeds.
**superset-frontend/src/utils/downloadUtils.ts**
```
// eslint-disable-next-line no-await-in-loop -- see above
await waitForRowsToLoad(batch, BATCH_LOAD_TIMEOUT_MS);
onProgress?.({
loadedBatches: index + 1,
totalBatches: rowBatches.length,
});
}
}
const allLoaded = await waitForChartsToLoad(container);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
