bito-code-review[bot] commented on PR #42787:
URL: https://github.com/apache/superset/pull/42787#issuecomment-5194681308
<!-- Bito Reply -->
The comments were added to document the transition to SQLAlchemy 2.0
behavior, where `cascade_backrefs=False` is used to prevent automatic session
cascading. To remove these comments, you must ensure that all code paths
creating or assigning these child objects (SSHTunnel, ReportRecipients, and
ReportExecutionLog) explicitly add them to the session (e.g.,
`session.add(obj)`). Once you have verified that all such locations in the
codebase are updated to handle session management explicitly, it is safe to
remove these explanatory comments.
**superset/databases/ssh_tunnel/models.py**
```
# SQLAlchemy 2.0 behavior: assigning `ssh_tunnel.database` no
# longer cascades the SSHTunnel into the Database's session;
# callers must add objects to a session explicitly.
cascade_backrefs=False,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
