dangdtr commented on PR #42474: URL: https://github.com/apache/superset/pull/42474#issuecomment-5199773048
Good catch, you’re right. Although `groupby` is deprecated at the query-object level, Sankey v2 still emits `columns: []` together with a populated `groupby`. <img width="1912" height="984" alt="2026-08-05_18-24" src="https://github.com/user-attachments/assets/5cb48318-5cd0-4b2a-b5e5-3b1b4c9c2949"; /> I updated the helper to match the schema behavior: prefer a truthy `groupby`, otherwise fall back to `columns`, and added regression coverage for this case. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
