Herestothegamers commented on PR #42603:
URL: https://github.com/apache/superset/pull/42603#issuecomment-5200427491
Follow-up with a deterministic repro of the `unit-tests` failure, on current
master (`442995481`), no PR changes involved:
```
TZ=UTC pytest
tests/unit_tests/mcp_service/common/test_time_range_validation.py # 75 passed
TZ=Etc/GMT+4 pytest
tests/unit_tests/mcp_service/common/test_time_range_validation.py # 2 failed —
same params as this PR's CI run
```
`TestValidateTimeRangeSubDayLast` asserts that `get_since_until("Last
hour")` always raises "From date cannot be larger than to date", but when the
process wall clock reads 00:00–01:00, `now − 1 hour` is still the previous day
— before the default `until` of today-midnight — so nothing raises and the test
fails. The test needs a frozen clock (e.g. `freeze_time("2026-01-01
12:00:00")`) around the premise check; happy to send that fix as a separate PR.
In the meantime, a re-run of the failed job should pass. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
