aminghadersohi commented on PR #42659: URL: https://github.com/apache/superset/pull/42659#issuecomment-5201266876
Addressed all four suggestions from the latest Bito review in `e038e93775`: - expanded the layout request docstring to explain permalink tab/filter context; - moved `GetDashboardPermalinkCommand` to a module-level import; - added an explicit regression assertion that mismatched permalink filter state is excluded; - centralized dashboard-ID matching, metadata redaction, and LLM sanitization in `get_matching_dashboard_permalink_state`, shared by both dashboard tools. The affected MCP tests pass (52 passed), along with Ruff and targeted mypy. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
