aminghadersohi commented on code in PR #42656:
URL: https://github.com/apache/superset/pull/42656#discussion_r3726551308
##########
superset/mcp_service/chart/tool/list_charts.py:
##########
@@ -80,7 +80,9 @@ async def list_charts(
"""List charts with filtering and search.
Returns chart metadata including id, name, viz_type, URL, and last
- modified time.
+ modified time. Set ``request.certified`` to true to prioritize governed
+ charts; false returns only uncertified charts, while omitting it preserves
+ the unfiltered behavior.
Review Comment:
Addressed in 440be3b6ea: the chart docstring now says `true` returns only
governed charts. I made the parallel dataset wording explicit as well.
##########
superset/mcp_service/chart/schemas.py:
##########
@@ -2198,6 +2198,19 @@ class ListChartsRequest(
):
"""Request schema for list_charts with clear, unambiguous types."""
+ certified: Annotated[
+ bool | None,
+ Field(
+ default=None,
+ description=(
+ "Filter by governance certification status. Use true to return
"
+ "only certified charts (preferred when selecting governed "
+ "assets), false to return only uncertified charts, or omit to "
+ "return both (default)."
+ ),
+ ),
+ ]
Review Comment:
Addressed in 440be3b6ea: both chart and dataset request schemas now use
`StrictBool`, with tests rejecting string and numeric coercions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
