rusackas commented on code in PR #42511:
URL: https://github.com/apache/superset/pull/42511#discussion_r3727795661
##########
.github/workflows/superset-frontend.yml:
##########
@@ -217,3 +217,99 @@ jobs:
- uses:
Kesin11/actions-timeline@7bf79990b7c09f5dfb570ac30b814ca597bd538e # v3.1.1
with:
expand-composite-actions: true
+
+ # Compares a PR's own bundle size against the last nightly-recorded
+ # baseline (see frontend-bundle-size-nightly.yml, which owns actually
+ # persisting new baselines). PR-only: a push to master doesn't need this
+ # check re-run against itself, and re-persisting the baseline on every
+ # push to master -- which happens many times a day -- would burn a full
+ # production build for no benefit nightly refresh doesn't already cover.
+ bundle-size:
+ needs: frontend-build
+ if: needs.frontend-build.outputs.should-run == 'true' && github.event_name
== 'pull_request'
+ runs-on: ubuntu-26.04
+ timeout-minutes: 15
+ permissions:
+ contents: read
+ pull-requests: write
+ steps:
+ - name: Checkout Code
Review Comment:
Good catch, fixed — pinned the `bundle-size` job's checkout to
`pull_request.head.sha` (same pattern the other jobs already use) so it matches
the revision the downloaded image was built from.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
