mikebridge commented on PR #42839: URL: https://github.com/apache/superset/pull/42839#issuecomment-5204519732
**Three-lens review panel** (react / clean-code / tidy-first) ran over the branch at `5908ab452c`. Verdict from all three: no blockers. The react lens control-verified every behavioural change in `5908ab452c` (reverted each, watched its test fail, restored byte-identical). Findings → dispositions, applied in `1a897649c8`: - **Deploy-skew hydration guard** (tidy-first + react, plausible-only → now guarded): an older backend omitting `description`/`cache_timeout` from `/structure` would have blanked the form, after which a save silently nulls the persisted description. Hydration now overwrites only when the field is present; explicit `null` still means "cleared". Discriminating test added (fails against the unguarded code — control run verified). - **Stranded `structureLoading`** (clean-code + react, verified, not user-visible with current callers): closing mid-fetch skipped the `.finally` reset; the early-return branch now fully resets closed state. - **`LARGE_STRUCTURE` fixture** now carries the two fields, matching the real wire shape. - **Seed-effect comment** corrected (the form is spinner-covered while `/structure` is in flight, so "populated while in flight" was wrong) and now records why the deps are keyed to open/identity. Noted but deliberately not done, for the record: a real FAB `get` detail route (the durable fix for `/structure`'s dual role — deferred as described in the PR body; do not extend this payload further without it), `AbortController` instead of the `cancelled` flag, a `seedDetails()` extraction, and renaming `SemanticViewStructure` → `…Response`. Disclosure: review panel and fixes by AI assistance (Claude), on behalf of and reviewed by @mikebridge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
