DanRoscigno commented on PR #42628:
URL: https://github.com/apache/superset/pull/42628#issuecomment-5204672957
Superseded by #42732, which landed the same nested unknown-field change for
#42626.
Closing in favour of #42841, which carries the one part of this PR that
isn't covered there: the `x_axis` collision on `XYChartConfig` and
`MixedTimeseriesChartConfig`. Those two classes accept `x_axis` as an alias for
the x column *and* declare an `x_axis: AxisConfig` styling field, so one input
key feeds both. Harmless while nested models ignored unknown keys; with strict
checking every spelling of `x_axis` is now rejected on those chart types,
including `x_axis: {"name": "category"}`, which worked before #42732.
#42732 met the same collision in `test_known_aliases_not_flagged_as_unknown`
and routed around it via `x_column`, documenting the ambiguity. #42841 removes
it, so both readings work again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
