mikebridge commented on PR #42534: URL: https://github.com/apache/superset/pull/42534#issuecomment-5206821916
Addressed the outstanding review feedback in `b41b3a3128`: - moved the `supports_samples` capability check after guest/dashboard and authenticated datasource authorization, with a regression test proving guest access is checked first - preserved multiline error formatting in `SamplesPane`, `useResultsPane`, and `DrillDetailPane` using a zero-margin `<pre>` with `white-space: pre-wrap`, with focused coverage in all three panes - rebased onto current `master`; the feature implementation already merged via #41509, so this PR is now a focused two-commit follow-up Local verification: 11 backend tests passed, 33 frontend tests passed, scoped pre-commit passed all applicable hooks, and the complete Python diff review found no issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
