rusackas commented on PR #39658: URL: https://github.com/apache/superset/pull/39658#issuecomment-5209301607
Nice fix for the crash, but the `CurrencyFormatter` branch just above stays unguarded — an AUTO-mode currency formatter can throw too. Worth wrapping that call in the same try/catch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
