rusackas commented on PR #36856: URL: https://github.com/apache/superset/pull/36856#issuecomment-5209395048
Turns out it wasn't a flake. fetch_data only sets g.bq_memory_limited when has_request_context() is true, which never holds in unit tests, so the assertions were failing deterministically. Patched that in the test and all 44 in test_bigquery.py pass now. Pushed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
