sadpandajoe opened a new pull request, #42879: URL: https://github.com/apache/superset/pull/42879
### SUMMARY The Group By display control in the dashboard filter bar renders its column-loading spinner with the default `<Loading position="inline" />`, i.e. full opacity and medium (70px) size. For an inline, secondary loading affordance this is visually heavy — the spinner should use the light grey/muted style, matching the muted inline variant already used by `FilterValue.tsx`. This change renders the spinner with the small, muted `Loading` variant (`size="s" muted` → 40px, 0.25 opacity) and adds a regression test that pins the card in its column-loading state and asserts the spinner is rendered small and muted. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Before: while column options load, the control shows the default spinner — full opacity, 70px — which dominates the filter card. After: the same loading state shows a 40px spinner at 0.25 opacity, reading as a light grey inline affordance. (Before/after recordings to follow.) ### TESTING INSTRUCTIONS 1. Open a dashboard with a Group By (dynamic group by) display control in the filter bar. 2. Trigger the column-options load for the control (e.g. first render with a configured dataset). 3. Observe the inline loading spinner under the control: it should render small and muted (light grey) instead of the full-opacity medium spinner. Automated: `npx jest src/dashboard/components/nativeFilters/FilterBar/FilterControls/GroupByFilterCard.test.tsx` — the new test fails on master (spinner opacity 1, width 70px) and passes with this change (opacity 0.25, width 40px). ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> - [ ] Has associated issue: - [ ] Required feature flags: - [x] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runs DB migration for a hive metastore - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
