codeant-ai-for-open-source[bot] commented on code in PR #42482:
URL: https://github.com/apache/superset/pull/42482#discussion_r3737089230
##########
scripts/change_detector.py:
##########
@@ -42,6 +42,7 @@
PATTERNS = {
"python": [
r"^\.github/workflows/.*python",
+ r"^\.github/workflows/scheduled-docker-image-refresh\.yml$",
Review Comment:
**Suggestion:** Adding this workflow to the `python` pattern causes every
change-detector consumer to emit `python=true`. As a result, a change limited
to the scheduled Docker refresh workflow starts the full Python unit,
integration, Presto/Hive, E2E, Playwright, CodeQL, dependency, translation, and
Docker-build jobs, creating a substantial unintended CI fan-out and potentially
changing required-status behavior. Use a dedicated workflow/config change
category or trigger only the focused regression coverage instead of classifying
this file as Python code. [performance]
<details>
<summary><b>Severity Level:</b> Major ⚠️</summary>
```mdx
- ❌ Workflow-only changes launch Python unit and integration tests.
- ❌ E2E, Presto/Hive, CodeQL, and Docker jobs also start.
- ⚠️ CI duration and runner consumption increase substantially.
- ⚠️ Required checks may change for Docker workflow edits.
```
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=35b46902b6fc4cadadf39df28557d33a&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=35b46902b6fc4cadadf39df28557d33a&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** scripts/change_detector.py
**Line:** 45:45
**Comment:**
*Performance: Adding this workflow to the `python` pattern causes every
change-detector consumer to emit `python=true`. As a result, a change limited
to the scheduled Docker refresh workflow starts the full Python unit,
integration, Presto/Hive, E2E, Playwright, CodeQL, dependency, translation, and
Docker-build jobs, creating a substantial unintended CI fan-out and potentially
changing required-status behavior. Use a dedicated workflow/config change
category or trigger only the focused regression coverage instead of classifying
this file as Python code.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42482&comment_hash=d01a51b5a4bcf983bd00874f2bac6e6c892eac0dfed1e108f53d28175e7faef2&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42482&comment_hash=d01a51b5a4bcf983bd00874f2bac6e6c892eac0dfed1e108f53d28175e7faef2&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
