bito-code-review[bot] commented on code in PR #42856: URL: https://github.com/apache/superset/pull/42856#discussion_r3737091095
########## pyproject.toml: ########## @@ -248,7 +248,7 @@ redshift = ["sqlalchemy-redshift>=0.8.1, <0.9"] # and 2.0 (version numbers don't track SQLAlchemy compat monotonically); pin # to the newest 1.4-only release for now. Bump to >=2.0.0 in lockstep with # Superset's own SQLAlchemy 2.0 core bump (discussion #40273), not before. -risingwave = ["sqlalchemy-risingwave>=1.4.1, <2.0.0"] +risingwave = ["sqlalchemy-risingwave>=2.1.0, <3.0.0"] Review Comment: <div> <div id="suggestion"> <div id="issue"><b>SQLAlchemy version gate violated</b></div> <div id="fix"> Bumping `sqlalchemy-risingwave` to `>=2.1.0` violates the documented prerequisite in the comments above (lines 247-250). The comment explicitly states: "Bump to >=2.0.0 in lockstep with Superset's own SQLAlchemy 2.0 core bump (discussion #40273), not before." The core constraint in `superset-core/pyproject.toml` line 48 remains `sqlalchemy>=1.4.0,<2.0`, confirming the SQLAlchemy 2.0 migration has not occurred. Since `sqlalchemy-risingwave>=2.1.0` requires SQLAlchemy 2.0+ (confirmed via vendor docs), installing the risingwave extra would create an unsatisfiable dependency. </div> </div> <small><i>Code Review Run #247a5a</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
