mikebridge commented on PR #42888: URL: https://github.com/apache/superset/pull/42888#issuecomment-5219624238
Addressed the automated review feedback: - The dataset-permission identity race was fixed in `38272dfae1`: permission identity is read from the database after the purge row is locked, and the existing inline thread has been replied to. - The ownership-path recursion suggestion was fixed in `744d41340f`: both depth ordering and owner-value predicate construction are iterative and detect cycles. Regression coverage exercises a 1,100-edge mapped ownership path through the actual predicate builder, plus a cyclic policy. - The filtered “missing visited state propagation” suggestion does not apply to the current implementation: `discover_dependencies()` and `_discover_table_dependencies()` both pass their updated `visited` set into recursive discovery, and `test_recursive_discovery_stops_at_owned_cycles` covers that behavior. Fresh local verification after the latest fix: `62 passed, 1 skipped`; changed-file pre-commit passed, including MyPy, Ruff, and Pylint; final Python review returned no findings. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
