bito-code-review[bot] commented on PR #42855:
URL: https://github.com/apache/superset/pull/42855#issuecomment-5219982713
<!-- Bito Reply -->
The flagged issue is correct. The current implementation only filters based
on the raw metric key, which fails when the data has been transformed (e.g.,
via `verboseMap` or time-comparison suffixes). To resolve this, you should
normalize the `extraMetricLabels` to match the rendered keys present in
`rebasedData` before performing the exclusion check.
To implement this, you can update the `extractDataTotalValues` function to
normalize the extra labels using the same logic applied to the series keys, or
ensure the `extraMetricLabels` passed to the function already reflect the final
rendered format used in the data records.
**superset-frontend/plugins/plugin-chart-echarts/src/utils/series.ts**
```
// Normalize extra labels to match the rendered keys in rebasedData
const normalizedExtraLabels = extraMetricLabels.map(label =>
// Apply the same transformation logic used for series keys here
getRenderedKey(label)
);
const extraMetricLabelsSet = new Set(normalizedExtraLabels);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
