rusackas commented on PR #38266: URL: https://github.com/apache/superset/pull/38266#issuecomment-5227586772
Took a look at this one. The actual fix here is small and valuable, wrapping the "You need access to the following tables..." error in `_()` in `security/manager.py` so it's translatable (matches #38268). The size of the diff is just the mechanical side effect of adding one new string to every catalog. Can't push to this branch to rebase it though, maintainer edits aren't enabled on this fork, and it's drifted a lot from current `master` since February. If you're able to enable maintainer edits or rebase it yourself, happy to take another pass. Otherwise we're glad to adopt just the `manager.py` fix into a fresh PR crediting you, or just talk through the approach if useful, let us know which you'd prefer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
