bito-code-review[bot] commented on PR #42921:
URL: https://github.com/apache/superset/pull/42921#issuecomment-5228519761
<!-- Bito Reply -->
The flagged issue is correct. The cloned `geojsonFillColorPicker` inherits
the default configuration from the shared `fillColorPicker`, which includes a
non-transparent default color. This causes the GeoJSON layer to override
feature-specific colors by default.
To resolve this, you should explicitly override the `default` property in
the `geojsonFillColorPicker` configuration to be transparent (e.g., `{ r: 0, g:
0, b: 0, a: 0 }`).
Here is the corrected implementation for
`superset-frontend/plugins/preset-chart-deckgl/src/layers/Geojson/controlPanel.ts`:
```typescript
const geojsonFillColorPicker = {
...fillColorPicker,
config: {
...fillColorPicker.config,
default: { r: 0, g: 0, b: 0, a: 0 },
visibility: () => true,
},
};
```
I have checked the PR comments, and there are no other pending review
comments to address.
**superset-frontend/plugins/preset-chart-deckgl/src/layers/Geojson/controlPanel.ts**
```
const geojsonFillColorPicker = {
...fillColorPicker,
config: {
...fillColorPicker.config,
default: { r: 0, g: 0, b: 0, a: 0 },
visibility: () => true,
},
};
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
