SaadAhmed7 commented on PR #42933: URL: https://github.com/apache/superset/pull/42933#issuecomment-5243712744
Sure thing @sadpandajoe — I've restructured the description with a **Before / After** section and am attaching the images to it now. For the short version: I reproduced it with a stacked bar chart where `Sales` + `Profit` are the displayed metrics and `SortMetric` is sort-only (values 500 / 400 / 300, never rendered as a series). - **Before:** the totals render as `530` / `440` / `350` on bars that are only `30` / `40` / `50` tall — the label openly contradicts the Y axis, because the hidden sort metric is summed in. - **After:** `30` / `40` / `50`, matching the bars. While putting that together I also picked up two cases from the automated review that the original patch missed, both now fixed and covered by unit tests: extra metric labels needed mapping through `verboseMap` to match the keys after `rebaseForecastDatum` renames them, and time-comparison derived keys (`SortMetric__1 year ago`) needed excluding too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
