eschutho commented on PR #42284: URL: https://github.com/apache/superset/pull/42284#issuecomment-5247720325
Verified the fix in f5869670 live end-to-end (same real Celery worker / MailHog / MinIO setup as before) — the exact scenario that was broken now works correctly: - `table` chart (`groupby: ["order_date"]`, `granularity_sqla: "order_date"`, `time_grain_sqla: "P1Y"`, `time_range: "No filter"`, on a dataset with real per-day granularity): now exports **3 correctly-bucketed yearly rows** matching a control chart with an explicit time range, instead of the previous 252 raw un-bucketed rows. - Also checked `pie` with the same groupby-own-time-column + "No filter" combination (hadn't tested that exact pairing before) — also correctly bucketed, and the contribution percentages check out (sum to 1.0). - Re-ran the full original test matrix (allowlisted happy paths, non-allowlisted skip, `_needs_unsupported_processing` guard, malformed-`query_context` recovery, in-flight export lock, images-mode feature-flag gate) — no regressions. - Full unit suite: 85 passed, including the regression test and its now-updated sibling test. Looks good from a correctness standpoint. Going to do a full code review pass on the current state next (a lot has landed since my first read — the config hook, Pie contribution post-processing, the raw-mode/order-by hardening — worth a fresh look rather than assuming my earlier review still covers it). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
