bito-code-review[bot] commented on code in PR #43005:
URL: https://github.com/apache/superset/pull/43005#discussion_r3754767197
##########
tests/unit_tests/sql/parse_tests.py:
##########
@@ -2830,6 +3029,63 @@ def test_rls_subquery_transformer(
assert statement.format() == expected
[email protected](
+ "sql, read_counts",
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Type mismatch in parametrize decorator</b></div>
<div id="fix">
The `rules` parameter in `test_rls_subquery_transformer` uses `dict[Table,
str]` but the test passes `dict[Table, list[exp.Node]]` at line 3033. Multiple
similar type mismatches likely exist in parameterized tests (rows 3000-3013).
</div>
</div>
<small><i>Code Review Run #c2ae3c</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
