aadhyap opened a new pull request, #43076: URL: https://github.com/apache/superset/pull/43076
## Summary `RisonFilterParser.parse()` currently catches `Exception` around both `prison.loads()` and `_convert_to_adhoc_filters()`. Malformed Rison raises `prison.decoder.ParserException`, so the exception handling can be narrowed to the parsing step. This preserves the current behavior for invalid Rison while allowing unexpected conversion errors to surface instead of being logged as parsing failures. ## Changes - Catch `prison.decoder.ParserException` around `prison.loads()` - Move `_convert_to_adhoc_filters()` outside the parsing `try` - Add tests for malformed Rison and unexpected conversion errors ## Testing - `pytest tests/unit_tests/utils/test_rison_filters.py` - 17 tests passed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
