rusackas commented on PR #42563: URL: https://github.com/apache/superset/pull/42563#issuecomment-5258665137
@ayush-sharaf LGTM! Nice parity with the drill-by logging, and gating on `showModal` makes sense since this modal stays mounted. Codeant's `chartId` concern is a fair question, but your rebuttal checks out. It's fixed for the life of each mounted instance at both call sites. Approving/merging! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
