rusackas commented on code in PR #42895:
URL: https://github.com/apache/superset/pull/42895#discussion_r3761911865
##########
superset/mcp_service/chart/schemas.py:
##########
@@ -790,10 +790,15 @@ class ColumnRef(UnknownFieldCheckMixin):
"MIN",
"MAX",
"COUNT_DISTINCT",
- "STDDEV",
- "VAR",
+ "STDDEV_SAMP",
+ "VAR_SAMP",
"MEDIAN",
"PERCENTILE",
+ # Pre-SIP shorthand, accepted and normalized to the names above by
+ # `chart_utils.create_metric_object`; kept here so schema
+ # validation doesn't reject them before that normalization runs.
+ "STDDEV",
+ "VAR",
Review Comment:
PERCENTILE was already accepted here before this PR, this diff doesnt touch
it. The SIP doc calls it out as unimplemented (needs a parameter this schema
has no field for) and explicitly out of scope for this change. Agreed it should
get rejected at the schema level eventually, thats a follow-up.
##########
superset/mcp_service/chart/schemas.py:
##########
@@ -790,10 +790,15 @@ class ColumnRef(UnknownFieldCheckMixin):
"MIN",
"MAX",
"COUNT_DISTINCT",
- "STDDEV",
- "VAR",
+ "STDDEV_SAMP",
+ "VAR_SAMP",
"MEDIAN",
"PERCENTILE",
+ # Pre-SIP shorthand, accepted and normalized to the names above by
+ # `chart_utils.create_metric_object`; kept here so schema
+ # validation doesn't reject them before that normalization runs.
+ "STDDEV",
+ "VAR",
Review Comment:
PERCENTILE was already accepted here before this PR, this diff doesn't touch
it. The SIP doc calls it out as unimplemented (needs a parameter this schema
has no field for) and explicitly out of scope for this change. Agreed it should
get rejected at the schema level eventually, that's a follow-up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
