AryaKetanShCt commented on PR #42927: URL: https://github.com/apache/superset/pull/42927#issuecomment-5266758520
@msyavuz @rusackas — this one is ready for review whenever you have a moment. Updated to `master` in `0ea7e84`. The conflict was a two-sided import addition in `tests/unit_tests/queries/query_object_test.py`: `master` added `Metric` and this branch added `pandas_postprocessing`. Both are kept, in isort order. The diff against `master` is unchanged at 250 insertions and 4 deletions across the same four files, and nothing from `master` was dropped — that file has zero deletions relative to `master`. State: - All three review threads resolved. The `df` finding from codeant-ai and both Copilot findings (`*args` in the supported set, and the log level) are fixed in code, not just answered. - Last full CI run on this branch was green across all 22 workflows. - Workflows on the new head are sitting at `action_required`, so they need an approval click before they can run. No rush on my end, and happy to split or reshape it if the scope is awkward to review as one change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
